feat: add pypi attestation discovery #1067
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Ben Selwyn-Smith <[email protected]>
benmss
force-pushed
the
947-discover-pypi-attestation
branch
from
b97a9cb to
a362d7c
Compare
Signed-off-by: Ben Selwyn-Smith <[email protected]>
benmss
force-pushed
the
947-discover-pypi-attestation
branch
from
2df212b to
6d7cf95
Compare
Signed-off-by: Ben Selwyn-Smith <[email protected]>
tromai
reviewed
Apr 29, 2025
tromai
reviewed
Apr 30, 2025
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 6, 2025
| @@ -83,6 +103,13 @@ def _load_provenance_file_content( | |||
| # Some provenances, such as Witness may not include the DSSE envelope `dsseEnvelope` | |||
| # property but contain its value directly. | |||
| provenance_payload = provenance.get("payload", None) | |||
| if not provenance_payload: | |||
| # GitHub Attestation. | |||
| # TODO Check if old method (above) actually works. | |||
There was a problem hiding this comment.
Could a doc string be added here - to explain the reason why there is a change in handling Github attestation?
There was a problem hiding this comment.
Perhaps @behnazh-w could weigh in on this?
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
| raise ValueError(f"Missing certificate value: {name}") | ||
|
|
||
| # Values are DER encoded UTF-8 strings. Removing the first two bytes seems to be sufficient. | ||
| value: str = certificate_claims[name][2:].decode("UTF-8") |
There was a problem hiding this comment.
Could we perform this operation in the first loop ?
for extension in certificate.extensions:
...
I think the purpose of this loop is for validating certificate_claims content, so in my opinion, it's best if we don't do extra mutation to certificate_claims.
There was a problem hiding this comment.
I have combined the loops.
There was a problem hiding this comment.
Thanks. It looks okay to me. Just a small observation that the logic for checking whether certificate_claims contains enough claim names (e.g. source_repo, source_digest, etc.) has been removed in the latest commit. Just want to make sure that this is intended.
There was a problem hiding this comment.
Good catch. I'll add it back in.
tromai
reviewed
May 7, 2025
tromai
reviewed
May 7, 2025
tromai
reviewed
May 7, 2025
tromai
requested changes
May 7, 2025
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
tromai
reviewed
May 8, 2025
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
tromai
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds discovery of PyPI attestation. URLs to these attestation files are sought via the deps.dev API.
Description of changes
DepsDevRepoFinderwas updated to use theDepsDevService, ensuring consistent and easily configurable use of the APIDepsDevRepoFinderfunctions (they were not added previously), including for the functions that PyPI attestation discovery relies upon.pypi-attestationis used to extract information from the attestation certificate. This information is coerced into a predicate for use elsewhere within Macaron.ultralyticsPython library as its target.Related issues
Closes #947